Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to only render and play selected region #1043

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

liuycsd
Copy link
Contributor

@liuycsd liuycsd commented Feb 17, 2024

This pull request tries to add a feature that only renders and plays selected region in the PianoRollWindow.

Only a simple play-region command via Alt+Space is provided in this PR.
It seems to work. But the UI interaction may need further improvement.

@stakira
Copy link
Owner

stakira commented Feb 25, 2024

Great feature!

However, I'm a little doubtful about soloing to a single track with any note selection. This makes users unable to listen to a section from all tracks. Maybe you don't need to add it. If a user wants to solo, they still have the option in the tracks view.

@liuycsd liuycsd force-pushed the pr-feature-play-region-1708136099 branch from 2194469 to 6f4858c Compare February 28, 2024 13:36
@liuycsd
Copy link
Contributor Author

liuycsd commented Feb 28, 2024

Great feature!

However, I'm a little doubtful about soloing to a single track with any note selection. This makes users unable to listen to a section from all tracks. Maybe you don't need to add it. If a user wants to solo, they still have the option in the tracks view.

OK. Fixed.

One more commit is added to skip rendering muted tracks (instead of calculating all the notes on those tracks then scaling the volume to zero). Although it's not perfect because it's only checked once when it starts rendering so canceling mute on those already skipped tracks won't actually work before current playback stops.
So I add an option for this behavior.

Besides, would it be better to use something like start / end markers on the time axis to mark the region to play, for all tracks?

@stakira stakira merged commit 2299728 into stakira:master Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants