Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G2p: add IsGlide method; EN ARPA: support glide phonemes. #1000

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

oxygen-dioxide
Copy link
Contributor

@oxygen-dioxide oxygen-dioxide commented Jan 2, 2024

This PR adds an IsGlide method to IG2p that tells whether a phoneme is a semivowel or liquid sound, like y, w, l, r in English.

In "Consonant - Glide - Vowel" syllables such as "grass", glide phoneme should be put after the start position of the note.

I've tested some external dll phonemizers released before this change. They work successfully as before.

@oxygen-dioxide
Copy link
Contributor Author

oxygen-dioxide commented Jan 2, 2024

TODO in the future:

  • Add glide support for Machine Learning phonemizers
  • Refactor G2pPack to make it fully portable. (Currently grapheme and phoneme definitions are hard coded in C# which makes it impossible to load external G2pPacks)

@oxygen-dioxide oxygen-dioxide changed the title g2p: add IsGlide method G2p: add IsGlide method; EN ARPA: support glide phonemes. Jan 2, 2024
@oxygen-dioxide oxygen-dioxide marked this pull request as ready for review January 2, 2024 05:26
@oxygen-dioxide
Copy link
Contributor Author

image

@stakira stakira merged commit 236f747 into stakira:master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants