Optionally skip regenerating geoparquet assets #24
+70
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
reviewed
Oct 27, 2022
src/stactools/goes_glm/constants.py
Outdated
| @@ -175,3 +175,131 @@ class OrbitalSlot(str, enum.Enum): | |||
| ] | |||
| ], | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The columns can't be constant as the columns vary slightly. Sometimes there are for example columns containing ...frame_time_offset..., sometimes they are missing (here it seems they are missing). So you need to read the files to get the actual content...
There was a problem hiding this comment.
Well, that's unfortunate! But thanks for the note. I'll get that info from the parquet file / netcdf file then.
There was a problem hiding this comment.
Ignore my latest commit, which really mangles parquet.create_asset. I intend to clean it up.
added 3 commits
October 27, 2022 11:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently,
stac.create_itemrequires creating the geoparquet assets if you want geoparquet metadata in the asset. This PR updatesstac.create_itemto accept geoparquet hrefs in addition to the NetCDF hrefs. If the geoparquet hrefs are provided then asset generation is skipped.WIP, since I haven't properly tested everything.
PR checklist:
scripts/format).scripts/lint).scripts/test).