Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allegro custom maven packages #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emmanu-bacancy
Copy link

Problem

Trello card
Allegro has some private packages that are added to the Kotlin project in a different pattern than the bibliothecary expects. So those packages are not detected.

Solution

Add custom regex to bibliothecary to detect the allegro private packages

Merge Checklist

The following items should be done before any PR can be approved and merged. A PR should be:

  • Descriptive. Describe the PR problem, solution, and attach a Trello card. The problem should be in your own words, not copy/pasted. Explain why you took this approach, and what alternatives you considered.
  • Fully unit tested. There is spec coverage for all new code, and spec coverage for modified code, within reason.
  • Small. A product PR should be less than a few hundred lines to be reasonably reviewable within a couple days. Don't submit big PRs for review on tight deadlines. Split big PRs into smaller PRs or contact lead engineers for guidance.
  • Secure & Private. The changes are secure by default and do not expose/leak any sensitive information to unauthorized requests, both logged in and logged out, and there is spec coverage confirming that.
  • Performant. All possible steps have been taken to ensure that the code written is as efficient as possible and will not introduce performance regressions for the code being added/changed or the website as a whole.

Draft PRs, hotfix PRs, and urgent debugging may be exempt from the items above.

Please follow the PR Review Guidelines before submitting your PR for review. Failure to follow the guidelines will result in a rejected review.

Copy link

@chetanror chetanror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@AkBacancy AkBacancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants