Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-024 Emergency Fix to Data Validation and Serialization Behavior #141

Merged
merged 3 commits into from
May 22, 2023

Conversation

pavitthrap
Copy link
Contributor

Draft PR for SIP 024.

This is an emergency SIP that discusses a resolution to a bug in the Clarity type system. The changes in this SIP will ideally roll out along with the changes discussed in SIP 022.

@pavitthrap pavitthrap requested review from obycode and wileyj May 12, 2023 18:58
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Outdated Show resolved Hide resolved
sips/sip-024/sip-024-least-supertype-fix.md Show resolved Hide resolved
@wileyj
Copy link
Contributor

wileyj commented May 15, 2023

pending the branch addition, looks good!

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approval is the official sign off from the Technical CAB.

@whoabuddy whoabuddy self-requested a review May 19, 2023 14:08
Copy link
Member

@whoabuddy whoabuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approval is the official sign off from the Governance CAB.

@whoabuddy whoabuddy changed the title added new sip SIP-024 Emergency Fix to Data Validation and Serialization Behavior May 19, 2023
(list (tuple (a 1)) (tuple (b 1) (a 1)))
```

The Clarity runtime will treat each item of this list as if it only
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obycode does clarity vm expects type of each item to match the type of "first element" from the list ? It is not clear from the example if the type should be intersection set of all keys or match the first element's keys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was treating all of the elements as the "least common super-type", so an intersection of all keys as you said.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction, my previous comment is wrong -- the ordering did matter, so it was based on the type of the first element. Later elements could have more fields, but not less.

@wileyj wileyj merged commit 7d8f925 into main May 22, 2023
@jiga
Copy link

jiga commented Jun 30, 2023

SIP Editor Update 6/30/2023:
RICE Details: Reach - 500,000, Impact - 3x, Confidence - 95%, Effort - 3 person-months.
Final RICE Score: 475,000

Status: Approved

Full details on this SIP can be seen in detail on the SIP impact assessment sheet where RICE scoring was conducted and tracked. Additional comments also available here:
https://docs.google.com/spreadsheets/d/1DsdUkZ99c6m7U57m7RnzSd0nni3vGdMIT80k-_zQUb0/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants