fix: Add additional deps to the notification job #1677
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jvdm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dcaravel
approved these changes
Oct 18, 2024
BradLugo
reviewed
Oct 18, 2024
| - upload-db-dump | ||
| - upload-dumps-for-downstream | ||
| - upload-dumps-for-embedding | ||
| - push-manifests | ||
| runs-on: ubuntu-latest | ||
| if: failure() |
There was a problem hiding this comment.
Do we want to be notified if these jobs fail at any point, e.g., including PRs? If not, we might want to add additional checks (not 100% sure if this is correct):
Suggested change
| if: failure() | |
| if: failure() && (github.ref_name == 'master' || startsWith(github.ref, 'refs/tags/')) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some leaf jobs in the dependency tree that were missing in the notification job dependencies, so that if these path fail, we see notifications.