feat: Use versioned offline defs in offline bundles #1643
Conversation
jvdm
force-pushed
the
jvdm/versioned-vulns-offline
branch
from
a8290fc
to
92a330e
Compare
Could you please send me the full review? I am OK waiting a bit for a full review, in case you're holding the remainder waiting for my replies on this preliminary. |
Called it preliminary due to not being tested yet:
|
Should we wait for that PR to be merged and for you to do your testing before reviewing this? |
I see this was already asked, and it seems like you still want a review, so I'll look |
|
Sorry I pressed the wrong button when submitting my comment 😬 |
scripts/ci/jobs/diff-dumps.sh
Outdated
| ;; | ||
| 4.5) | ||
| # Backward compatibility, the "schema version" is the release itself. | ||
| version="$release" |
There was a problem hiding this comment.
what happens in the next iteration of the loop? seems like version gets overwritten
jvdm
force-pushed
the
jvdm/versioned-vulns-offline
branch
from
92a330e
to
3c79493
Compare
|
@jvdm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Update the offline bundle workflow to use versioned offline definitions (create based on https://github.com/stackrox/stackrox/pull/12516/files) instead of release-based defintions. Also, from 4.6.x onward, versioned offline bundles are published by Z-stream.
Test
In progress, waiting on https://github.com/stackrox/stackrox/pull/12516/files for full end-to-end testing.