ROX-19980 pre-built scanner-db image #1310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at 4328d2f. To use the images, use the tag |
ludydoo
force-pushed
the
ROX-19980-scanner-db-contention
branch
from
906063a
to
7e434d1
Compare
|
/retest |
SimonBaeumer
reviewed
Nov 2, 2023
Comment on lines
+11
to
+21
| echo "Creating /var/lib/postgresql/data/pgdata..." | ||
| mkdir -p /var/lib/postgresql/data/pgdata | ||
|
|
||
| echo "Moving archive to target directory..." | ||
| mv /tmp/data.tar.gz /var/lib/postgresql/data/pgdata/data.tar.gz | ||
|
|
||
| echo "Uncompressing into /var/lib/pgsql/data/pgdata..." | ||
| tar -xzf /var/lib/postgresql/data/pgdata/data.tar.gz -C /var/lib/postgresql/data/pgdata | ||
|
|
||
| echo "Removing archive..." | ||
| rm /var/lib/postgresql/data/pgdata/data.tar.gz |
There was a problem hiding this comment.
@jvdm @RTann Could we move these steps to build time instead of start-up time?
@ludydoo proposes this to save IO in the cloud service which prevents us from cluster upgrades and increases ACS upgrade complexity.
Every restart of ACS instances causes to write ~1.8GB per instance.
Additionally the manifest must be updated that the scanner-db pod can read the Postgres Password.
What do you think about this approach? It seems simple and scaleable to us.
cc @ludydoo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.