Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26065: Uninstall observability CSV on uninstalling the helm chart #2076

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Oct 18, 2024

Description

When uninstalling the observability subchart, csv remains together with the controller manager.
This change adds a delete hook that deletes the csv upon the subchart uninstall.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur force-pushed the yury/ROX-26065-uninstall-observability-csv branch from 14b1f24 to 8a5b0db Compare October 18, 2024 19:04
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur force-pushed the yury/ROX-26065-uninstall-observability-csv branch from 8a5b0db to cbe7213 Compare November 13, 2024 09:33
@openshift-ci openshift-ci bot removed the lgtm label Nov 13, 2024
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

New changes are detected. LGTM label has been removed.

@kovayur kovayur force-pushed the yury/ROX-26065-uninstall-observability-csv branch 2 times, most recently from f9c420c to f15b5ce Compare November 14, 2024 16:46
@kovayur kovayur force-pushed the yury/ROX-26065-uninstall-observability-csv branch from f15b5ce to 601716f Compare November 18, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants