Handle mixed case names in build-image workflows #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflows fail if the GitHub organization name or repository name use mixed case, since Docker only supports lower-cased image names. Updated to use the docker/metadata-action tags output since that action handles the normalization.
JAORMX
previously approved these changes
Oct 8, 2024
rdimitrov
previously approved these changes
Oct 9, 2024
rdimitrov
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflows fail if the GitHub organization name or repository name use mixed case (such as the Stacklok-Demo-Org), since Docker only allows lower-cased image names.
Updated to use the docker/metadata-action tags output since that action handles the normalization.
Also had to handle in the Makefile for the "malicious" steps.