Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove markgoddard from teams #336

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: remove markgoddard from teams #336

merged 1 commit into from
Sep 23, 2024

Conversation

jackhodgkiss
Copy link
Contributor

Remove @markgoddard from all teams within the organisation. This does mean many teams are without a maintainer. Can be resolved here or within follow up PR.

@jackhodgkiss jackhodgkiss self-assigned this Sep 20, 2024
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner September 20, 2024 16:00
@stackhpc-ci
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @jackhodgkiss, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add @priteau in a few places where Mark is being removed, especially where Mark was the only maintainer. Probably worth more of a discussion with the infra team leads

Copy link
Contributor

@MaxBed4d MaxBed4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell Cap'n 🫡

@priteau
Copy link
Member

priteau commented Sep 23, 2024

I think we should add @priteau in a few places where Mark is being removed, especially where Mark was the only maintainer. Probably worth more of a discussion with the infra team leads

This is quite theoretical, as the main role of team maintainers is to manage team membership, but we do it via CI instead: https://docs.github.com/en/organizations/organizing-members-into-teams/assigning-the-team-maintainer-role-to-a-team-member

@jackhodgkiss jackhodgkiss merged commit 4bdbdef into main Sep 23, 2024
4 checks passed
@jackhodgkiss jackhodgkiss deleted the remove-mark branch September 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants