Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support branch-specific branch protection rules #235

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

Alex-Welsh
Copy link
Contributor

Updates status checks so that different branches in a repo can have different checks

@Alex-Welsh Alex-Welsh force-pushed the branch-status-checks branch 5 times, most recently from 48879b1 to 0a6c847 Compare August 30, 2023 13:33
@stackhpc-ci
Copy link
Contributor

stackhpc-ci commented Aug 30, 2023

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @Alex-Welsh, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@Alex-Welsh Alex-Welsh marked this pull request as ready for review August 30, 2023 14:09
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner August 30, 2023 14:09
@Alex-Welsh Alex-Welsh force-pushed the branch-status-checks branch from 743c595 to 13e29a5 Compare August 30, 2023 14:12
@Alex-Welsh
Copy link
Contributor Author

Bit of a faff but looks like it's working now

terraform/github/branches.tf Outdated Show resolved Hide resolved
terraform/github/branches.tf Outdated Show resolved Hide resolved
terraform/github/branches.tf Outdated Show resolved Hide resolved
terraform/github/terraform.tfvars.json Outdated Show resolved Hide resolved
@Alex-Welsh Alex-Welsh force-pushed the branch-status-checks branch from 13e29a5 to c3cadcd Compare August 31, 2023 08:38
@Alex-Welsh
Copy link
Contributor Author

Not sure why terraform fmt is failing. Works when I run it locally

@markgoddard
Copy link

Not sure why terraform fmt is failing. Works when I run it locally

It fails for me. Are you running it in the terraform/github directory?

@markgoddard
Copy link

I'm using latest version 1.5.6

@Alex-Welsh
Copy link
Contributor Author

Not sure why terraform fmt is failing. Works when I run it locally

It fails for me. Are you running it in the terraform/github directory?

Might help if I had the right branch checked out. 🤦‍♂️

@Alex-Welsh Alex-Welsh merged commit 778ab14 into main Sep 4, 2023
@Alex-Welsh Alex-Welsh deleted the branch-status-checks branch September 4, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants