Skip to content

Commit

Permalink
hardware: Correct log
Browse files Browse the repository at this point in the history
We currently get the following error message if attempting to fit a
guest with hugepages on a node that doesn't have enough:

  Host does not support requested memory pagesize, or not enough free
  pages of the requested size. Requested: -2 kB

Correct this, removing the kB suffix and adding a note on the meaning of
the negative values, like we have for the success path.

Change-Id: I247dc0ec03cd9e5a7b41f5c5534bdfb1af550029
Signed-off-by: Stephen Finucane <[email protected]>
Closes-Bug: #2075959
(cherry picked from commit 4678bcb)
(cherry picked from commit f619311)
(cherry picked from commit 6147a05)
  • Loading branch information
stephenfin authored and gibizer committed Sep 7, 2024
1 parent da40da6 commit cf08543
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion nova/virt/hardware.py
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,9 @@ def _numa_fit_instance_cell(
if not pagesize:
LOG.debug('Host does not support requested memory pagesize, '
'or not enough free pages of the requested size. '
'Requested: %d kB', instance_cell.pagesize)
'Requested memory pagesize: %d '
'(small = -1, large = -2, any = -3)',
instance_cell.pagesize)
return None
LOG.debug('Selected memory pagesize: %(selected_mem_pagesize)d kB. '
'Requested memory pagesize: %(requested_mem_pagesize)d '
Expand Down

0 comments on commit cf08543

Please sign in to comment.