Skip to content

Commit

Permalink
mariadb: Fix RPM repository URLs
Browse files Browse the repository at this point in the history
The MariaDB project changed the location of the repositories, and the
old URLs no longer work.

Fix added for stable branches: Wrap version detection for docker module
since it can fail for docker >= 6.0.

Closes-Bug: #1988121

Change-Id: Ia094cd1e29232c47d1fb26e00de569677bc5b8a1
(cherry picked from commit 94fad9f)
(cherry picked from commit b3e7221)
  • Loading branch information
markgoddard authored and yoctozepto committed Aug 31, 2022
1 parent bc4890b commit bf43419
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 13 deletions.
6 changes: 3 additions & 3 deletions docker/base/mariadb-aarch64.repo
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[mariadb]
name = MariaDB
baseurl = https://downloads.mariadb.com/MariaDB/mariadb-10.5/yum/centos8-aarch64
module_hotfixes = 1
name = MariaDB Server
baseurl = https://dlm.mariadb.com/repo/mariadb-server/10.5/yum/rhel/8/aarch64
gpgcheck = 1
enabled = 0
module_hotfixes = 1
6 changes: 3 additions & 3 deletions docker/base/mariadb.repo
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[mariadb]
name = MariaDB
baseurl = https://downloads.mariadb.com/MariaDB/mariadb-10.5/yum/centos8-amd64
module_hotfixes = 1
name = MariaDB Server
baseurl = https://dlm.mariadb.com/repo/mariadb-server/10.5/yum/rhel/8/x86_64
gpgcheck = 1
enabled = 0
module_hotfixes = 1
11 changes: 8 additions & 3 deletions kolla/image/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,14 @@ def push_image(self, image):

# Since docker 3.0.0, the argument of 'insecure_registry' is removed.
# To be compatible, set 'insecure_registry=True' for old releases.
dc_running_ver = StrictVersion(docker.version)
if dc_running_ver < StrictVersion('3.0.0'):
kwargs['insecure_registry'] = True
# NOTE(frickler): The version check will fail for docker >= 6.0, but
# in that case we know that the workaround isn't needed.
try:
dc_running_ver = StrictVersion(docker.version)
if dc_running_ver < StrictVersion('3.0.0'):
kwargs['insecure_registry'] = True
except TypeError:
pass

for response in self.dc.push(image.canonical_name, **kwargs):
if 'stream' in response:
Expand Down
8 changes: 4 additions & 4 deletions kolla/template/repos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ debian:
component: "main"
gpg_key: "elasticsearch.asc"
mariadb:
url: "http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/debian"
url: "https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/debian"
suite: "bullseye"
component: "main"
gpg_key: "mariadb.gpg"
Expand Down Expand Up @@ -126,7 +126,7 @@ debian-aarch64:
component: "main"
gpg_key: "elasticsearch.asc"
mariadb:
url: "http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/debian"
url: "https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/debian"
suite: "bullseye"
component: "main"
gpg_key: "mariadb.gpg"
Expand Down Expand Up @@ -183,7 +183,7 @@ ubuntu:
component: "main"
gpg_key: "elasticsearch.asc"
mariadb:
url: "http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/ubuntu"
url: "https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/ubuntu"
suite: "focal"
component: "main"
gpg_key: "mariadb.gpg"
Expand Down Expand Up @@ -235,7 +235,7 @@ ubuntu-aarch64:
component: "main"
gpg_key: "elasticsearch.asc"
mariadb:
url: "http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/ubuntu"
url: "https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/ubuntu"
suite: "focal"
component: "main"
gpg_key: "mariadb.gpg"
Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/docker-6-6d77b5ff7ec1daef.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Fixes problems when running with docker-py >=6.
`LP#1988121 <https://launchpad.net/bugs/1988121>`__

0 comments on commit bf43419

Please sign in to comment.