Skip to content

Commit

Permalink
mariadb: Fix repository URLs
Browse files Browse the repository at this point in the history
The MariaDB project changed the location of the repositories, and the
old URLs no longer work.

Fix added for stable branches: Wrap version detection for docker module
since it can fail for docker >= 6.0.

Closes-Bug: #1988121

Change-Id: Ia094cd1e29232c47d1fb26e00de569677bc5b8a1
(cherry picked from commit 94fad9f)
(cherry picked from commit b3e7221)
  • Loading branch information
markgoddard authored and yoctozepto committed Aug 31, 2022
1 parent a7b00b0 commit b64e717
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 7 deletions.
11 changes: 8 additions & 3 deletions kolla/image/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,9 +332,14 @@ def push_image(self, image):

# Since docker 3.0.0, the argument of 'insecure_registry' is removed.
# To be compatible, set 'insecure_registry=True' for old releases.
dc_running_ver = StrictVersion(docker.version)
if dc_running_ver < StrictVersion('3.0.0'):
kwargs['insecure_registry'] = True
# NOTE(frickler): The version check will fail for docker >= 6.0, but
# in that case we know that the workaround isn't needed.
try:
dc_running_ver = StrictVersion(docker.version)
if dc_running_ver < StrictVersion('3.0.0'):
kwargs['insecure_registry'] = True
except TypeError:
pass

for response in self.dc.push(image.canonical_name, **kwargs):
if 'stream' in response:
Expand Down
8 changes: 4 additions & 4 deletions kolla/template/repos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ debian:
influxdb: "deb https://repos.influxdata.com/debian bullseye stable"
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
kibana: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/debian bullseye main"
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/debian bullseye main"
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian bullseye main"
td-agent: "deb http://packages.treasuredata.com/4/debian/bullseye bullseye contrib"

Expand All @@ -75,7 +75,7 @@ debian-aarch64:
influxdb: "deb https://repos.influxdata.com/debian bullseye stable"
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
kibana: "deb [arch=amd64] https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/debian bullseye main"
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/debian bullseye main"
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian bullseye main"
td-agent: "deb http://packages.treasuredata.com/4/debian/bullseye bullseye contrib"

Expand All @@ -86,7 +86,7 @@ ubuntu:
influxdb: "deb https://repos.influxdata.com/ubuntu focal stable"
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
kibana: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/ubuntu focal main"
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/ubuntu focal main"
qdrouterd: "deb http://ppa.launchpad.net/qpid/released/ubuntu/ focal main"
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu focal main"
td-agent: "deb http://packages.treasuredata.com/4/ubuntu/focal/ focal contrib"
Expand All @@ -97,7 +97,7 @@ ubuntu-aarch64:
grafana: "deb https://packages.grafana.com/oss/deb stable main"
influxdb: "deb https://repos.influxdata.com/ubuntu focal stable"
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/ubuntu focal main"
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/ubuntu focal main"
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu focal main"
td-agent: "deb http://packages.treasuredata.com/4/ubuntu/focal/ focal contrib"

Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/docker-6-6d77b5ff7ec1daef.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Fixes problems when running with docker-py >=6.
`LP#1988121 <https://launchpad.net/bugs/1988121>`__

0 comments on commit b64e717

Please sign in to comment.