Fix territory form label clicks not toggling correct input #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all the post types checkbox are being assigned the same "postTypes" id, so clicking on any of the post type labels always toggles the first one. If you inspect the HTML, all the post type labels have 'for="postTypes"' which is how the HTML knows which checkbox to toggle. We have to keep the "name" attribute the same because that's how the checkbox values are linked to the postTypes field. To fix, we explicitly assign the id prop for each checkbox so that the <label>'s "for" attribute is tied to the correct checkbox input.
Currently, all the billing types radios are being assigned the same "billingType" id, so clicking on any of the labels always selects the monthly one. If you inspect the HTML, all the billing type labels have 'for="billingType"' which is how the HTML knows which input to select. We have to keep the "name" attribute the same because that's how the input values are linked to the billingType form field. To fix, we explicitly assign the "id" prop for each radio so that the <label>'s "for" attribute is tied to the correct radio input.
mzivil
force-pushed
the
fix-territory-form-labels
branch
from
da63ceb
to
f2f39f4
Compare
|
Dang how did no one report that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the territory form, clicking on the labels of the "post types" or "billing" options don't toggle the correct input:
Feb-03-2024.16-49-26.mp4
All the labels within each group were being assigned the same html "id" since we were falling back to the "name" prop. We need to keep the "name" prop the same because that's how the form associates the value with the correct form field. Fix is to assign explicit "id" prop to each checkbox so that the label toggles the correct input.
Feb-03-2024.16-55-58.mp4