Fix hacker news and bitcointalk dupes #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like a regression was introduced at some point, because the `uri` that's compared against the `whitelist` is a regular expression and not the url hostname + pathname as it was originally written. This brings back the original behavior of comparing the whitelist against the hostname + pathname
|
Excellent! Figures there was a regression at one point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #768
Looks like there was a regression at some point that made all hacker news links and all bitcointalk links appear as dupes.
Originally, we expected that these links would be caught by the
whitelist.includes(uri)if-condition, but nowuriis a regex string (like(%.)?bitcointalk.org(:[0-9]+)?/index.php) so we never matched correctly against the whitelist values.This returns the original behavior of checking the whitelist against the URL's hostname + pathname. It also renames a variable and reassigns the previously mutated variables to new variables for clarity.