Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment, Reply count singular/plural labels #382

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

SatsAllDay
Copy link
Contributor

This PR updates the Comment and ItemInfo components to render comment/reply counts using the appropriate singular/plural label, based on the number of comments/replies.

Apparently this has bothered me enough to fix it :)

@SatsAllDay SatsAllDay marked this pull request as ready for review August 7, 2023 20:39
@huumn huumn merged commit 9941bc6 into stackernews:master Aug 8, 2023
1 check passed
@huumn
Copy link
Member

huumn commented Aug 8, 2023

Thank you! Please give me a lightning address to send some sats to

@SatsAllDay
Copy link
Contributor Author

Thank you! Please give me a lightning address to send some sats to

You're welcome! Does this work?

lnurl1dp68gurn8ghj7ampd3kx2ar0veekzar0wd5xjtnrdakj7tnhv4kxctttdehhwm30d3h82unvwqhhymm4va58qunfwdhkudfhzfar3r

@SatsAllDay SatsAllDay deleted the reply-replies-label branch August 8, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants