fix lightning module resolution #1551
Open
+668
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts the revert of #1521. It aims to fix the module resolution we're seeing when locating
.protofiles forlightningby locating them beforewebpackruns and storing them in an environment variableLIGHTNING_MODULE_PATH.After spending most of the day trying to write my own version of nextjs's module resolution, I realized we were just using
tsxweirdly by making modules of our own directories. Not doing that allowsrequire.resolveto work inworkerand avoid some of the weird tricks we used to deal with CJS deps in the worker.I still need to test if this works in production, but it should because
require.resolve- when not using webpack - returns an absolute path.