fix vault key changes not seen by all instances of useVault #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1543
Description
This problem was caused by only one
useVaultConfiguratorreceiving the new key when a device is connected. I had been assuming theuseEffectwould capture this update on connect - but it doesn't becauseme.privates.vaultKeyHashchanges before the device is connected.This adds apollo's
reactiveVarto create a global var holding the vault key now so that if one instance changes it, all instances change.Bonus
I made it so that if the local key hash doesn't match, we unsync any local wallets to local storage.