fix #1538 #1539
Merged
fix #1538 #1539
+23
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobl
reviewed
Nov 5, 2024
There was a problem hiding this comment.
This fixes it, thanks.
But empty fields do not use the default values, eg. if i type nothing into the currency field it will error saying configuration must be able to send or receive because the currency field is empty, while it should be set to BTC by the validation
.transform(value => value ? value.toUpperCase() : 'BTC')
riccardobl
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
With this and: #1540
everything is back to work as expected 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1538
afaict this fixes the cyclical dep issue. Breaking cyclical deps in yup requires pairs of tie breakers, e.g.
[['apiKey', 'apiKeyRecv'],['currency', 'currencyRecv']]. Before #1479, we were coincidentally tie breaking using an array of all field names (with sometimes more than 2 members).I did not read the issue fully before that describes this escape hatch: jquense/yup#176 (comment)
QA:
6. I couldn't test blink in full, but it passes validation now if one of field pairs are set and doesn't pass if neither of them are. I also disabled validation on the client to test it on the server (it also fails if bothrequiredWithoutfields aren't set, and succeeds if one is set).