Fix global wallet logs never fetch logs from server #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
force-pushed
the
fix-global-wallet-logs
branch
from
1d7c05c
to
be212d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we're on /wallet/logs, we want to show logs from all wallets. For that, we pass no wallet to
useWalletLogsbut the underlying function to fetch logs assumed there is always one set and only fetched local logs in the case of no wallet.Additional Context
I've seen that I basically reverted the line change in 2bdbb43 so I made sure that WebLN still saves. I think the previous line was correct and changing it was just an oversight.
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
5. I made sure that NWC logs and LNbits are fetched fine individually (locally + from server) and globally.For frontend changes: Tested on mobile? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no