Enable WebLN wallet on 'webln:enabled' #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #945
This listens for
webln:enabledand enables the attached wallet responsible for WebLN. This means that stackers only need to enable WebLN once by logging in with lightning which will optimistically call thewindow.weblnstuff or by clicking on the QR code during payments. After that, following payments will first try to use the WebLN wallet using our wallet code like any other wallet before showing any QR code.I think only running WebLN optimistically during login and not also during payments is a good compromise since the user will be asked to enable WebLN during login. If they do, the WebLN wallet is also enabled which will then call the
window.weblnstuff optimistically because we use our attached wallets optimistically.Video
WebLN is optimistically called during Login with Lightning; enabling our WebLN wallet on connect:
2024-09-10.17-37-47.mp4
Clicking on QR code for payments prompts WebLN; also enabling our WebLN wallet on connect:
2024-09-10.16-32-48.mp4
Additional Context
I've added a listener for
webln:disabledeven though it doesn't fire. Ideally, we would also disable the attached wallet since I think that would match user expectations.Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
9.99Did you introduce any new environment variables? If so, call them out explicitly here:
no