Don't notify on own posts

stackernews · Jan 11, 2024 · cf04b85 · cf04b85
1 parent 672e64d
commit cf04b85
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/api/resolvers/notifications.js b/api/resolvers/notifications.js
@@ -112,7 +112,7 @@ export default {
           `SELECT "Item".*, "Item".created_at AS "sortTime", 'TerritoryPost' AS type
             FROM "Item"
             JOIN "Sub" ON "Item"."subName" = "Sub".name
-            WHERE "Sub"."userId" = $1
+            WHERE "Sub"."userId" = $1 AND "Item"."userId" <> $1
             ORDER BY "sortTime" DESC
             LIMIT ${LIMIT}+$3`
         )

diff --git a/lib/push-notifications.js b/lib/push-notifications.js
@@ -100,9 +100,16 @@ export const notifyZapped = async ({ models, id }) => {
 export const notifyFounders = async ({ models, item }) => {
   try {
     const isPost = !!item.title
+
+    // only notify on posts in subs
     if (!isPost || !item.subName) return
+
     const author = await models.user.findUnique({ where: { id: item.userId } })
     const sub = await models.sub.findUnique({ where: { name: item.subName } })
+
+    // don't send notifications on own posts to founders
+    if (sub.userId === author.id) return
+
     const tag = `TERRITORY_POST-${sub.name}`
     await sendUserNotification(sub.userId, {
       title: `@${author.name} created a post in ~${sub.name}`,