Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): fix hanging shells #159

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix(npm): fix hanging shells #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c192386
fix(npm): fix hanging shells (#153)
samdenty Oct 7, 2024
375364b
fix: oops
samdenty Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/lib/runtime/action-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ export class ActionRunner {

const webcontainer = await this.#webcontainer;

const process = await webcontainer.spawn('jsh', ['-c', action.content]);
const process = await webcontainer.spawn('jsh', ['-c', action.content], {
env: { npm_config_yes: true },
});

action.abortSignal.addEventListener('abort', () => {
process.kill();
Expand Down
1 change: 0 additions & 1 deletion app/utils/shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export async function newShellProcess(webcontainer: WebContainer, terminal: ITer
cols: terminal.cols ?? 80,
rows: terminal.rows ?? 15,
},
env: { npm_config_yes: true },
});

const input = process.input.getWriter();
Expand Down