fix(npm): fix hanging shells (#159)

stackblitz · Oct 7, 2024 · 31c07c0 · 31c07c0
1 parent d0828e4
commit 31c07c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/lib/runtime/action-runner.ts b/app/lib/runtime/action-runner.ts
@@ -128,7 +128,9 @@ export class ActionRunner {
 
     const webcontainer = await this.#webcontainer;
 
-    const process = await webcontainer.spawn('jsh', ['-c', action.content]);
+    const process = await webcontainer.spawn('jsh', ['-c', action.content], {
+      env: { npm_config_yes: true },
+    });
 
     action.abortSignal.addEventListener('abort', () => {
       process.kill();

diff --git a/app/utils/shell.ts b/app/utils/shell.ts
@@ -11,7 +11,6 @@ export async function newShellProcess(webcontainer: WebContainer, terminal: ITer
       cols: terminal.cols ?? 80,
       rows: terminal.rows ?? 15,
     },
-    env: { npm_config_yes: true },
   });
 
   const input = process.input.getWriter();