-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use operator-rs Duration #412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear this will not be possible so easy.
Something something product-config something something legacy something something
Relevant code:
superset-operator/deploy/config-spec/properties.yaml
Lines 36 to 57 in 50f3937
- property: &webserverTimeout | |
propertyNames: | |
- name: "SUPERSET_WEBSERVER_TIMEOUT" | |
kind: | |
type: "file" | |
file: "superset_config.py" | |
datatype: | |
type: "integer" | |
defaultValues: | |
- fromVersion: "0.0.0" | |
value: "60" # 1 min | |
recommendedValues: | |
# The default timeout of Superset is 60s which is way to low when querying "big data" systems. | |
# Especially Trino queries often take longer. | |
# see [the Superset docs](https://superset.apache.org/docs/frequently-asked-questions#why-are-my-queries-timing-out). | |
- fromVersion: "0.0.0" | |
value: "300" # 5 min | |
roles: | |
- name: "node" | |
required: true | |
asOfVersion: "0.0.0" | |
description: "Maximum number of seconds a Superset request can take before timing out. This settings effect the maximum duration a query to an underlying datasource can take. If you get timeout errors before your query returns the result you can need to increase this timeout. Corresponds to SUPERSET_WEBSERVER_TIMEOUT" |
I removed the property from the product config. This seems like a logical step, as we try to move away from the product config mechanism. |
We decided to delay the CRD change until our CRD versioning is in place. This PR now only replaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Part of stackabletech/operator-rs#649