Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use operator-rs Duration #412

Merged
merged 8 commits into from
Oct 20, 2023
Merged

refactor: Use operator-rs Duration #412

merged 8 commits into from
Oct 20, 2023

Conversation

Techassi
Copy link
Member

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this will not be possible so easy.
Something something product-config something something legacy something something
Relevant code:

- property: &webserverTimeout
propertyNames:
- name: "SUPERSET_WEBSERVER_TIMEOUT"
kind:
type: "file"
file: "superset_config.py"
datatype:
type: "integer"
defaultValues:
- fromVersion: "0.0.0"
value: "60" # 1 min
recommendedValues:
# The default timeout of Superset is 60s which is way to low when querying "big data" systems.
# Especially Trino queries often take longer.
# see [the Superset docs](https://superset.apache.org/docs/frequently-asked-questions#why-are-my-queries-timing-out).
- fromVersion: "0.0.0"
value: "300" # 5 min
roles:
- name: "node"
required: true
asOfVersion: "0.0.0"
description: "Maximum number of seconds a Superset request can take before timing out. This settings effect the maximum duration a query to an underlying datasource can take. If you get timeout errors before your query returns the result you can need to increase this timeout. Corresponds to SUPERSET_WEBSERVER_TIMEOUT"

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
@Techassi
Copy link
Member Author

I fear this will not be possible so easy. Something something product-config something something legacy something something Relevant code:

- property: &webserverTimeout
propertyNames:
- name: "SUPERSET_WEBSERVER_TIMEOUT"
kind:
type: "file"
file: "superset_config.py"
datatype:
type: "integer"
defaultValues:
- fromVersion: "0.0.0"
value: "60" # 1 min
recommendedValues:
# The default timeout of Superset is 60s which is way to low when querying "big data" systems.
# Especially Trino queries often take longer.
# see [the Superset docs](https://superset.apache.org/docs/frequently-asked-questions#why-are-my-queries-timing-out).
- fromVersion: "0.0.0"
value: "300" # 5 min
roles:
- name: "node"
required: true
asOfVersion: "0.0.0"
description: "Maximum number of seconds a Superset request can take before timing out. This settings effect the maximum duration a query to an underlying datasource can take. If you get timeout errors before your query returns the result you can need to increase this timeout. Corresponds to SUPERSET_WEBSERVER_TIMEOUT"

I removed the property from the product config. This seems like a logical step, as we try to move away from the product config mechanism.

@Techassi Techassi marked this pull request as ready for review October 13, 2023 08:03
@Techassi Techassi requested a review from sbernauer October 16, 2023 11:10
@Techassi
Copy link
Member Author

We decided to delay the CRD change until our CRD versioning is in place. This PR now only replaces Duration in non-CRD parts of the code.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Techassi Techassi added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit c0f5a8e Oct 20, 2023
@Techassi Techassi deleted the refactor/duration branch October 20, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants