Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

chore: Remove demo and stack files #291

Merged
merged 6 commits into from
Dec 7, 2023
Merged

chore: Remove demo and stack files #291

merged 6 commits into from
Dec 7, 2023

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Nov 9, 2023

@Techassi Techassi self-assigned this Nov 9, 2023
@Techassi Techassi mentioned this pull request Nov 9, 2023
Closed
@sbernauer
Copy link
Member

Just for the record: We need to be aware that merging this will break "old" stackablectl versions.
IMHO we should at least keep https://github.com/stackabletech/stackablectl/blob/b71ca62337d4bef92d159ea4cf76502b51faae5e/stacks/stacks-v1.yaml and add a similar notice to stacks-v2.yaml (same demo files)

@Techassi
Copy link
Member Author

Techassi commented Nov 9, 2023

Yes, this will break old stackablectl. I quite like the notice. I will add it to this PR!

@Techassi
Copy link
Member Author

Techassi commented Nov 9, 2023

I updated the stack and demo definition files. Both versions now point to the documentation on how to get started with the new stackablectl version.

@Techassi Techassi marked this pull request as ready for review November 9, 2023 11:23
@sbernauer
Copy link
Member

Thanks!

sbernauer
sbernauer approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update https://docs.stackable.tech/management/stable/stackablectl/installation.html to install 23.11.1 before merging

@Techassi
Copy link
Member Author

Techassi commented Dec 7, 2023

PR has landed: stackabletech/stackable-cockpit#159

@Techassi Techassi added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 2efd503 Dec 7, 2023
6 of 13 checks passed
@Techassi Techassi deleted the chore/demo-stack-migration branch December 7, 2023 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @sbernauer