Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add shell completions for Nushell and Elvish #337

Merged
merged 5 commits into from
Nov 20, 2024
Merged

feat: Add shell completions for Nushell and Elvish #337

merged 5 commits into from
Nov 20, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Nov 19, 2024 •
edited
Loading

Description

  • Nushell completions.
    Uses the clap_complete_nushell crate, as linked by the already used clap_complete crate.
  • Elvish completions.
    Already included in clap_complete, so why not?
  • Update xtasks to generate the new shell completions.
  • New xtask command to run all xtasks (useful for local development).
  • Disable shellcheck on generated completions.

@NickLarsenNZ NickLarsenNZ self-assigned this Nov 19, 2024
Techassi
Techassi requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to minor comments.

rust/stackablectl/CHANGELOG.md Outdated Show resolved Hide resolved
extra/completions/stackablectl.elv Outdated Show resolved Hide resolved
extra/completions/stackablectl.nu Outdated Show resolved Hide resolved
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit a60b677 Nov 20, 2024
29 of 30 checks passed
@NickLarsenNZ NickLarsenNZ deleted the additional-shell-completions branch November 20, 2024 10:48
This was referenced Nov 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
type/feature-new
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickLarsenNZ @Techassi