Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Rust, Go and Node dependencies #238

Merged
merged 12 commits into from
May 13, 2024
Merged

chore: Bump Rust, Go and Node dependencies #238

merged 12 commits into from
May 13, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented May 13, 2024 •
edited
Loading

Description

This PR bumps various Rust and Node dependencies. Should resolve #185, #211, #221, #225, #229 and #230.

Reviewer
Preview Give feedback

@Techassi Techassi added the type/dependencies Pull requests that update a dependency file label May 13, 2024
@Techassi Techassi self-assigned this May 13, 2024
@Techassi Techassi changed the title chore: Bump Rust and Node dependencies chore: Bump Rust, Go and Node dependencies May 13, 2024
@Techassi
Copy link
Member Author

I will include the setup-go action in other workflows as well, so that we can more easily control which Go version is used (instead of using the one provided by the image).

@Techassi Techassi marked this pull request as ready for review May 13, 2024 11:42
@Techassi
Copy link
Member Author

The "Publish Docker Image" step fails, because some Nix stuff fails. I'm out of my depth to determine what the exact issue is. Maybe @nightkr or @NickLarsenNZ can take a look.

@Techassi Techassi requested a review from a team May 13, 2024 11:49
@nightkr
Copy link
Member

nightkr commented May 13, 2024

I can take a look.

@nightkr
Copy link
Member

nightkr commented May 13, 2024

Tilt is happy as of ba1e2a7, hopefully GitHub should be too.

@NickLarsenNZ NickLarsenNZ self-requested a review May 13, 2024 14:15
NickLarsenNZ
NickLarsenNZ previously approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left comments which are optional to action now.

Cargo.toml Outdated Show resolved Hide resolved
default.nix Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
NickLarsenNZ
NickLarsenNZ previously approved these changes May 13, 2024
View reviewed changes
@Techassi Techassi enabled auto-merge May 13, 2024 15:05
NickLarsenNZ
NickLarsenNZ approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection 👌

@Techassi Techassi added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 525f36e May 13, 2024
43 checks passed
@Techassi Techassi deleted the chore/update-deps branch May 13, 2024 15:08
@Techassi Techassi mentioned this pull request May 13, 2024
Merged
@sbernauer
Copy link
Member

Recalling my last big Go bump you lucky ones :) Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr left review comments

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels
type/dependencies Pull requests that update a dependency file
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Techassi @nightkr @sbernauer @NickLarsenNZ