Skip to content

Commit

Permalink
added comment and changelog entry
Browse files Browse the repository at this point in the history
  • Loading branch information
adwk67 committed Dec 19, 2024
1 parent b9b6100 commit 8af0471
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 13 deletions.
12 changes: 6 additions & 6 deletions extra/completions/_stackablectl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions extra/completions/stackablectl.fish

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions rust/stackablectl/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ All notable changes to this project will be documented in this file.
### Added

- Add new argument `--release` that allows installing a specific version of a demo or stack ([#340]).
- Add new argument `--chart-source` so that operator charts can be pulled either from an OCI registry (the default) or from a Nexus repository ([#344]).

### Removed

- Remove argument `--offline` that was not implemented yet ([#340]).

[#340]: https://github.com/stackabletech/stackable-cockpit/pull/340
[#344]: https://github.com/stackabletech/stackable-cockpit/pull/344

## [24.11.1] - 2024-11-20

Expand Down
7 changes: 6 additions & 1 deletion rust/stackablectl/src/cli/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,16 @@ pub enum ChartSourceTypeArg {
#[default]
OCI,

/// Nexus repositories: resolution (dev, test, stable) is based on the version and thus may be operator-specific
/// Nexus repositories: resolution (dev, test, stable) is based on the version and thus will be operator-specific
Repo,
}

impl From<ChartSourceTypeArg> for ChartSourceType {
/// Resolves the enum used by clap/arg-resolution to the core type used in
/// stackable-cockpit. For the (Nexus-)repo case this core type cannot be
/// decorated with meaningful information as that would be operator-specific
/// i.e. we cannot resolve *which* Nexus repo to use until we have inspected
/// the operator version. Hence just a simple mapping.
fn from(cli_enum: ChartSourceTypeArg) -> Self {
match cli_enum {
ChartSourceTypeArg::OCI => ChartSourceType::OCI,
Expand Down

0 comments on commit 8af0471

Please sign in to comment.