-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement resource requests and limits for OPA pods #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
changed the title
Resource limits
Implement resource requests and limits for OPA pods
Sep 15, 2022
3 tasks
sbernauer
reviewed
Sep 16, 2022
sbernauer
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % opa-latest discussion
sbernauer
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
# Description - added cpu and memory resource limits fixes #325 This currently only sets resource limits for the `opa` container. I created an issue #348 in case we ever need to provide the `opa-bundle-builder` container with more resources. Test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/12/ Co-authored-by: Malte Sander <[email protected]>
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Implement resource requests and limits for OPA pods
[Merged by Bors] - Implement resource requests and limits for OPA pods
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #325
This currently only sets resource limits for the
opa
container. I created an issue #348 in case we ever need to provide theopa-bundle-builder
container with more resources.Test:
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/12/
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information