Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(regionserver): add graceful shutdown configuration #570

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

feat(regionserver): add graceful shutdown configuration #570

wants to merge 52 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Oct 2, 2024 •
edited by siegfriedweber
Loading

Description

part of: #508

requires: stackabletech/docker-images#898

Implementation for "approach B" in https://github.com/stackabletech/decisions/issues/30

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@razvan razvan marked this pull request as ready for review October 14, 2024 16:24
@razvan razvan requested a review from a team October 14, 2024 16:24
@razvan razvan self-assigned this Oct 15, 2024
@razvan razvan mentioned this pull request Oct 15, 2024
Closed
@razvan razvan marked this pull request as draft October 15, 2024 15:53
@razvan razvan mentioned this pull request Oct 17, 2024
Merged
@razvan razvan marked this pull request as ready for review October 17, 2024 13:58
NickLarsenNZ
NickLarsenNZ reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Show resolved Hide resolved
rust/crd/src/affinity.rs Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
razvan and others added 11 commits October 24, 2024 17:57
@razvan @siegfriedweber
Update rust/crd/src/lib.rs
420ba36 
Co-authored-by: Siegfried Weber <[email protected]>
@razvan @siegfriedweber
Update rust/crd/src/lib.rs
2b0d63b 
Co-authored-by: Siegfried Weber <[email protected]>
@razvan @siegfriedweber
Update rust/crd/src/lib.rs
5d5d5e9 
Co-authored-by: Siegfried Weber <[email protected]>
@razvan @siegfriedweber
Update docs/modules/hbase/pages/usage-guide/operations/graceful-shutd…
228ad4f 
…own.adoc

Co-authored-by: Siegfried Weber <[email protected]>
@razvan @siegfriedweber
Update docs/modules/hbase/pages/usage-guide/operations/graceful-shutd…
039c22a 
…own.adoc

Co-authored-by: Siegfried Weber <[email protected]>
@razvan @siegfriedweber
Update docs/modules/hbase/pages/usage-guide/operations/graceful-shutd…
60b9dc8 
…own.adoc

Co-authored-by: Siegfried Weber <[email protected]>
@razvan @siegfriedweber
Update docs/modules/hbase/pages/usage-guide/operations/graceful-shutd…
fd8331e 
…own.adoc

Co-authored-by: Siegfried Weber <[email protected]>
@razvan @siegfriedweber
Update rust/crd/src/lib.rs
5378f11 
Co-authored-by: Siegfried Weber <[email protected]>
@razvan
main merge
7b08a26
@razvan
note on constant paths and the entrypoint script
6f087db
@razvan
remove unnecessary configOverrides
0f32e59
@razvan razvan requested a review from siegfriedweber October 28, 2024 13:21
siegfriedweber
siegfriedweber requested changes Oct 29, 2024
View reviewed changes
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
siegfriedweber
siegfriedweber previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan mentioned this pull request Jan 15, 2025
Open
@razvan
Copy link
Member Author

razvan commented Jan 17, 2025

Updated and it now requires stackabletech/docker-images#974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber left review comments

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

@sbernauer sbernauer Awaiting requested review from sbernauer

Requested changes must be addressed to merge this pull request.

Assignees

@razvan razvan

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@razvan @NickLarsenNZ @siegfriedweber @sbernauer