-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add example to pod placement #413
Conversation
docs/modules/hbase/pages/usage-guide/operations/pod-placement.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hbase/pages/usage-guide/operations/pod-placement.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hbase/pages/usage-guide/operations/pod-placement.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hbase/pages/usage-guide/operations/pod-placement.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Lars Francke <[email protected]>
Co-authored-by: Lars Francke <[email protected]>
@@ -104,7 +104,7 @@ In the examples above `cluster-name` is the name of the HBase custom resource th | |||
NOTE: It is important that the `hdfsConfigMapName` property contains the name the HDFS cluster. You could instead configure ConfigMaps of specific name or data roles, but for the purpose of pod placement, this will lead to faulty behavior. | |||
|
|||
== Use custom pod placement | |||
xref:concepts:operations/pod_placement.adoc[] describes how you can configure pod placement in general. | |||
xref:concepts:operations/pod_placement.adoc[The concepts page on Pod Placement] describes how you can configure pod placement in general. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but: How does this look in a rendered version now?
I wanted to avoid the duplication of "Pod placement"
And: It should be "placement" not "Placement"
And: You have "Pod" once and "pod" another time. We should be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed lower and upper case.
Currently it reads
The concepts page on Pod placement describes how you can configure Pod placement in general.
We could change it to e.g.
This concepts page describes how you can configure Pod placement in general.
but I have been told to not have "click this" links, but instead tell the user where the link is pointing too.
But I don't have a strong opinion and let you decide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion:
For general configuration of Pod placement, see the [Pod placement concepts] page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 2996c2f
1. Co-locate all the HBase Pods (weight 20) | ||
2. Co-locate HBase regionservers with the underlying HDFS datanodes (weight 50) | ||
3. Distribute all Pods within the same role (masters, regionservers, rest servers) (weight 70) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, reading this again now, I have a new suggestion.
1. Co-locate all the HBase Pods (weight 20) | |
2. Co-locate HBase regionservers with the underlying HDFS datanodes (weight 50) | |
3. Distribute all Pods within the same role (masters, regionservers, rest servers) (weight 70) | |
1. Co-locate all the HBase Pods (weight 20) | |
2. Co-locate HBase regionservers with the underlying HDFS datanodes (weight 50) | |
3. Distribute all Pods within the same role across nodes so multiple instances don't end up on the same Kubernetes node (masters, regionservers, rest servers) (weight 70) |
Point 1 needs clarification but I don't know exactly how. What is it we do exactly there?
And we should point out (I thought we did somewhere) that this is "only" preferred not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 30eba1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. But what does the first point actually mean?
"Co-locate al the HBase Pods"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its the first rule in the example below
affinity:
podAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- podAffinityTerm:
labelSelector:
matchLabels:
app.kubernetes.io/instance: cluster-name
app.kubernetes.io/name: hbase
topologyKey: kubernetes.io/hostname
weight: 20
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- podAffinityTerm:
labelSelector:
matchLabels:
app.kubernetes.io/component: master
app.kubernetes.io/instance: cluster-name
app.kubernetes.io/name: hbase
topologyKey: kubernetes.io/hostname
weight: 70
I just pulls all HBase Pods together, so that e.g. hbase master + regionserver + restserver run on the same node to reduce latency.
…adoc Co-authored-by: Lars Francke <[email protected]>
Thanks! |
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance