Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ciso8601 with pyiso8601 #448

Merged
merged 3 commits into from
Aug 5, 2022
Merged

replace ciso8601 with pyiso8601 #448

merged 3 commits into from
Aug 5, 2022

Conversation

geospatial-jeff
Copy link
Collaborator

@geospatial-jeff geospatial-jeff commented Aug 5, 2022

Related Issue(s):

Description:
Replaces the ciso8601 dependency with pyiso8601, following validation logic recommended in the stac api implementation guide:

  • Upper case the date string.
  • Match against the regex ^(\d\d\d\d)\-(\d\d)\-(\d\d)(T|t)(\d\d):(\d\d):(\d\d)([.]\d+)?(Z|([-+])(\d\d):(\d\d))$
  • Parse with pyiso8601.

The date parsing unittests are quite good and all pass with pyiso8601.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@geospatial-jeff
Copy link
Collaborator Author

Need to add types test cases to ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ciso8601 as an optional dependency
2 participants