Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: simplify start node cmd #1843

Draft
wants to merge 12 commits into
base: stage
Choose a base branch
from
Draft

Conversation

iurii-ssv
Copy link
Contributor

@iurii-ssv iurii-ssv commented Nov 8, 2024

Rebased onto #1819 (only 1 last commit in this PR is new, throw away the rest because it will be impossible to rebase once #1819 is squash-merged)

Run function of StartNodeCmd is a bit hard to navigate (due to it's size), plus it's poorly structured - this PR tries to simplify it by:

  • grouping related code together (where applicable)
  • splitting off pieces of Run function into separate helper-funcs

this PR is in Draft for now - it depends on the following PRs to be merged first:

(notes to self) after that ^ finish the following sub-tasks:

  • (where applicable) group initialization of related cfg settings together
  • move blocks of code out of StartNodeCmd.Run into separate funcs in todo.go
  • split todo.go into appropriately named files

Before merging:

  • test on stage

@iurii-ssv iurii-ssv marked this pull request as draft November 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant