fix: gosec warnings #1785
Merged
fix: gosec warnings #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshe-blox
reviewed
Oct 10, 2024
protocol/v2/types/ssvshare.go
Outdated
| @@ -157,7 +157,7 @@ func ComputeCommitteeID(committee []spectypes.OperatorID) spectypes.CommitteeID | |||
| // Convert to bytes | |||
| bytes := make([]byte, len(committee)*4) | |||
| for i, v := range committee { | |||
| binary.LittleEndian.PutUint32(bytes[i*4:], uint32(v)) // nolint:gosec | |||
| binary.LittleEndian.PutUint32(bytes[i*4:], uint32(v)) // #nosec | |||
There was a problem hiding this comment.
let's please disable only the specific rule to avoid missing any future rules
moshe-blox
reviewed
Oct 10, 2024
eth/eventhandler/handlers.go
Outdated
| @@ -95,6 +95,7 @@ func (eh *EventHandler) handleOperatorAdded(txn basedb.Txn, event *contract.Cont | |||
| return nil | |||
| } | |||
|
|
|||
| // This function is currently no-op and it will do nothing. Operator removed event is not used in the current implementation. | |||
There was a problem hiding this comment.
i think we can remove the commented code inside and move this comment there instead, also clarifying that it will do nothing - beyond validating the operator exists, and that we should consider removing the operator and updating the shares in the future
There was a problem hiding this comment.
also opened an issue #1786
moshe-blox
approved these changes
Oct 10, 2024
y0sher
approved these changes
Oct 10, 2024
iurii-ssv
pushed a commit
to iurii-ssv/ssv
that referenced
this pull request
Oct 16, 2024
* resolve gosec issues * add comment to clarify handleOperatorRemoved implementation * fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.