Alter the logic how peer identities are recorded

ssvlabs · Dec 2, 2024 · 73b6b24 · 73b6b24
1 parent b9c7af3
commit 73b6b24
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/network/p2p/observability.go b/network/p2p/observability.go
@@ -65,6 +65,7 @@ func recordPeerCountPerTopic(ctx context.Context, ctrl topics.Controller) func()
 
 func recordPeerIdentities(ctx context.Context, peers []peer.ID, index peers.Index) func() {
 	return func() {
+		peersByVersion := make(map[string]int64)
 		for _, pid := range peers {
 			nodeVersion := "unknown"
 			ni := index.NodeInfo(pid)
@@ -73,7 +74,10 @@ func recordPeerIdentities(ctx context.Context, peers []peer.ID, index peers.Inde
 					nodeVersion = ni.Metadata.NodeVersion
 				}
 			}
-			peerIdentityGauge.Record(ctx, 1, metric.WithAttributes(attribute.String("ssv.node.version", nodeVersion)))
+			peersByVersion[nodeVersion]++
+		}
+		for version, peerCount := range peersByVersion {
+			peerIdentityGauge.Record(ctx, peerCount, metric.WithAttributes(attribute.String("ssv.node.version", version)))
 		}
 	}
 }