-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update]: deployment tests and update task and documentation #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mohsen-T
commented
Nov 22, 2023
•
edited
Loading
edited
- Deployment and Verification on Goerli Testnet: Successfully deployed all contracts on the Goerli testnet and subsequently verified each one post-deployment.
- Contract Upgrade and Testing: Upgraded the SSVNetwork to SSVNetworkValidatorsPerOperator, followed by re-verification and testing of the new functionalities.
- Module Update Testing: Conducted comprehensive testing to ensure all requirements for updating modules were met.
- Documentation Updates: Enhanced the /docs section with additional descriptions, focusing on contract verification, issue resolution, module updates, and related topics.
- Ticket: Deployment tests
- deployed all contracts on the goerli-testnet - verified all contracts after deployment - upgraded SSVNetworkValidatorsPerOperator and verified again, tested new value - tested to update module by adding SSVOperatorsGetOperator with additional external function
andrew-blox
requested changes
Nov 23, 2023
andrew-blox
approved these changes
Nov 29, 2023
mtabasco
approved these changes
Nov 30, 2023
liorrutenberg
pushed a commit
that referenced
this pull request
Feb 15, 2024
* event ValidatorExited -> indexed owner * fix: added a test case in balance.ts * fix: reviewed the balance calculation when an operator is removed * Update balances.ts * fix: added a test case * fix: removed only * fix: progressing * fix: updated test case * fix: removed log * [Feature] - Integration ssv-keys in ssv-network for generating keyshares (#276) * feat: updated validators & operators management using ssv-keys * [Update]: deployment tests and update task and documentation (#282) * fix: updated documentations * [Update] Added triggers for compilation in a few tasks (upgrading / updating) (#285) * feat: added trigger for compilation in tasks * fix: changed before test * bulk validator registration (init) * 2 register validator functions, all tests pass * refactor cluster and operators libraries * V1.0.2 deployment metadata (#283) * v1.0.2 deployment metadata * Bulk registration of validators (#287) * bulk validator registration * update CHANGELOG * bulk remove validators * upgrade goerli prod * bulk exit validator * hlsky dev metadata * add exit validator tests * update CHANGELOG * update gas usage * update roles doc * minor improvements * v1.1.0 goerli_prod metadata * remove abis from git * remove liquidation check (duplicate) * Fix: updated the test coverage Enhanced test coverage by incorporating additional test cases to address previously overlooked scenarios * fix: bulkRemoveValidators reduce validator counter * fix: bulkRemoveValidator all tests passed * update gas numbers * update NatSpec comments * add audit report * holesky deployment metadata --------- Co-authored-by: Mohsen-T <[email protected]> Co-authored-by: Mohsen-T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.