[Feature] - Integration ssv-keys in ssv-network for generating keyshares #276

Mohsen-T · 2023-11-08T18:55:09Z

Added ssv-keys as a dependency modeul to the ssv-network project’s within package.json, temporarily using v1.0.5-dev tag of ssv-keys
Established a directory named json within the Hardhat's test folder, designated for housing the validatorKeys.json and operatorKeys.json files.
Conducted updates to contract-helpers.ts to enhance functionality with these functions: registerValidators, registerOperators, getSecretSharedPayload, and etc
Revised all test cases to accommodate the newly integrated functions in contract-helpers.ts
Eliminated redundant constants and functions from contract-helpers.ts to streamline the codebase.
Used the Prettier plugin to beautify and format Solidity, Typescript codes
Ticket: Use ssv-keys sdk to generate share in tests

* remove registerAuth implementation * remove test * remove all references to registerAuth in tests

* fix sequential network withdrawals issue

* A validator can voluntarily exit

* Update local-dev.md

* fix Types.shrink

* add SSVViews.getNetworkValidatorsCount()

… jato-v2

- integrated ssv-keys - added a new folder named keystore, encompass the test-keystore.json, operatorIds.json, operatorKeys.json - added new function registerValidatorsWithKeystore in contract-helpers.ts - added test case in register.ts - used Prettier plugin to beautify and format Solidity & Typescript

- keystores: array of keystore files json string - passwords: array of keystore files password - operatorIds: array of operator ids - operatorKeys: array of operator key strings

test/keystore/test.keystore.json

test/keystore/operatorIds.json

test/helpers/contract-helpers.ts

- added validatorKeys.json and operatorKeys.json in json folder - updated registerValidators() and registerOperators functions - changed execution codes related new functions in all test scripts - removed unnecessary constants and functions

mtabasco

@Mohsen-T well done!
A suggestion: move the json folder into the helpers one. thanks!

test/helpers/contract-helpers.ts

package.json

test/account/withdraw.ts

andrew-blox · 2023-11-23T16:47:34Z

test/account/withdraw.ts

  });

  it('Withdraw from operator balance emits "OperatorWithdrawn"', async () => {
-    await expect(ssvNetworkContract.connect(helpers.DB.owners[0]).withdrawOperatorEarnings(1, helpers.CONFIG.minimalOperatorFee)).to.emit(ssvNetworkContract, 'OperatorWithdrawn');
+    await expect(
+      ssvNetworkContract.connect(helpers.DB.owners[0]).withdrawOperatorEarnings(1, helpers.CONFIG.minimalOperatorFee),


here is example of single line

* event ValidatorExited -> indexed owner * fix: added a test case in balance.ts * fix: reviewed the balance calculation when an operator is removed * Update balances.ts * fix: added a test case * fix: removed only * fix: progressing * fix: updated test case * fix: removed log * [Feature] - Integration ssv-keys in ssv-network for generating keyshares (#276) * feat: updated validators & operators management using ssv-keys * [Update]: deployment tests and update task and documentation (#282) * fix: updated documentations * [Update] Added triggers for compilation in a few tasks (upgrading / updating) (#285) * feat: added trigger for compilation in tasks * fix: changed before test * bulk validator registration (init) * 2 register validator functions, all tests pass * refactor cluster and operators libraries * V1.0.2 deployment metadata (#283) * v1.0.2 deployment metadata * Bulk registration of validators (#287) * bulk validator registration * update CHANGELOG * bulk remove validators * upgrade goerli prod * bulk exit validator * hlsky dev metadata * add exit validator tests * update CHANGELOG * update gas usage * update roles doc * minor improvements * v1.1.0 goerli_prod metadata * remove abis from git * remove liquidation check (duplicate) * Fix: updated the test coverage Enhanced test coverage by incorporating additional test cases to address previously overlooked scenarios * fix: bulkRemoveValidators reduce validator counter * fix: bulkRemoveValidator all tests passed * update gas numbers * update NatSpec comments * add audit report * holesky deployment metadata --------- Co-authored-by: Mohsen-T <[email protected]> Co-authored-by: Mohsen-T <[email protected]>

mtabasco and others added 24 commits August 30, 2023 12:49

Remove registerAuth implementation (#257)

5f23870

* remove registerAuth implementation * remove test * remove all references to registerAuth in tests

remove pending registerAuth

530dd5d

deploy stage-dev 30082023

50db186

deploy stage v1.0.0.rc4

b8e03e7

Fix network withdrawals (#262)

a0c2914

* fix sequential network withdrawals issue

A validator can voluntarily exit (#263)

8324ce8

* A validator can voluntarily exit

Update local-dev.md (#260)

3da66d3

* Update local-dev.md

Fix Types.shrink() (#265)

c8679b3

* fix Types.shrink

v1.0.0.rc5

e6db598

goerli_dev deployment

16e2da5

Remove validator gas costs metrics (#266)

9e6d64b

holesky dev (#267)

2bc27cc

Get Network total validators count (#270)

fa9173b

* add SSVViews.getNetworkValidatorsCount()

testnet holesky (#268)

756f01e

change input modifiers

97407a1

Merge branch 'jato-v2' of https://github.com/bloxapp/ssv-network into…

c70a513

… jato-v2

rename __gap (#269)

7220109

OperatorLib gas optimizations (#273)

4cb7bbf

remove named return params (#272)

670a075

add msg.sender to ValidatorExited event (#271)

4331945

remove storage checks

f7e59b9

feat: updated params of registerValidatorsWithKeyStores

f74b717

- keystores: array of keystore files json string - passwords: array of keystore files password - operatorIds: array of operator ids - operatorKeys: array of operator key strings

Merge branch 'main' into mohsen-feature-generate-shares-using-ssvkeys

3137476

Mohsen-T requested review from mtabasco, liorrutenberg and andrew-blox November 8, 2023 19:04

mtabasco requested changes Nov 10, 2023

View reviewed changes

Mohsen-T requested a review from mtabasco November 15, 2023 09:08

mtabasco approved these changes Nov 16, 2023

View reviewed changes

mtabasco reviewed Nov 16, 2023

View reviewed changes

test/helpers/contract-helpers.ts Outdated Show resolved Hide resolved

mtabasco and others added 4 commits November 16, 2023 14:11

fix slither CI

bae3f81

fix: changed json path and version

09f7921

Merge branch 'main' into mohsen-feature-generate-shares-using-ssvkeys

7d0b940

fix: changed gas group constant

36ba81a

Mohsen-T requested a review from mtabasco November 17, 2023 08:29

mtabasco approved these changes Nov 17, 2023

View reviewed changes

fix: added ownerNonce in DB for ssv-keys

94071be

andrew-blox approved these changes Nov 27, 2023

View reviewed changes

fix: updated ssv-keys latest stable version

5b0d3be

mtabasco changed the base branch from main to v1.1.0 December 5, 2023 10:04

mtabasco added 2 commits December 5, 2023 11:34

merge with v1.0.0

5c87625

fix package.lock

10c77f6

mtabasco merged commit 7564dfe into v1.1.0 Dec 5, 2023
4 checks passed

mtabasco deleted the mohsen-feature-generate-shares-using-ssvkeys branch December 5, 2023 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] - Integration ssv-keys in ssv-network for generating keyshares #276

[Feature] - Integration ssv-keys in ssv-network for generating keyshares #276

Mohsen-T commented Nov 8, 2023 •

edited

Loading

mtabasco left a comment

andrew-blox Nov 23, 2023

[Feature] - Integration ssv-keys in ssv-network for generating keyshares #276

[Feature] - Integration ssv-keys in ssv-network for generating keyshares #276

Conversation

Mohsen-T commented Nov 8, 2023 • edited Loading

mtabasco left a comment

Choose a reason for hiding this comment

andrew-blox Nov 23, 2023

Choose a reason for hiding this comment

Mohsen-T commented Nov 8, 2023 •

edited

Loading