improve sanitaze function #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshin-dev
approved these changes
Sep 13, 2023
| } | ||
| if (!fs.existsSync(filePath.trim())) { | ||
| return message || 'Couldn’t locate keystore file or directory.'; | ||
| } |
| base64: publicKey, | ||
| }, | ||
| error.message, | ||
| ); |
There was a problem hiding this comment.
Can we provide also operator ID in this exception? It will help higher layers of software to identify operator by ID and easily for instance highlight it in interface or similar
|
Before merging this, there was message from @arielssv about breaking change with |
axelrod-blox
approved these changes
Nov 8, 2023
* multi-shares logic and improvements in design * new logic * fix examples and tests * import/export improvement * update examples * updated tests * updated tests * add keyshares construct init new flow * update build
alexstolr
approved these changes
Dec 10, 2023
* add more covered tests and updated errors * version up to 1.0.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>