merlin/hr_router: support user-defined portcontrol subcomponents #2424
Conversation
For my use-case, I wish to assign bandwidths to local ports different from router-to-router port bandwidths. Although a mechanism exists in hr_router to set heterogeneous port control parameters, it relies on topology logical groups, which is too coarse for assigning properties to local ports (and it's only really used by the dragonfly topology). This patch checks for user-defined subcomponents on an hr_router's portcontrol slots during initialization and assigns them to the associated port. This is enough to override any port settings by setting the subcomponent on any router after building a topology in pymerlin. Also includes a small unit-conversion fix for flit_size in portControl that turned up while testing.
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
I will take a look at this later this week, but for the use case you describe (different bandwidth on local/endpoint ports), there is a simpler mechanism (assuming the local ports are lower bandwidth, which is probably a safe assumption). Each pair of ports that is connected will "negotiate" the final bandwidth used by the ports by exchanging the set bandwidths and using the lower of the two bandwidths. So, if you just set the bandwidth of the NICs to be the local bandwidth, those ports will negotiate down to that bandwidth and the routers will use the same bandwidth (again, assuming this bandwidth is lower than the router to router bandwidth). If you want to control other ports, than something more complex may be needed. |
For my use-case, I wish to assign bandwidths to local ports different from router-to-router port bandwidths. Although a mechanism exists in hr_router to set heterogeneous port control parameters, it relies on topology logical groups, which is too coarse for assigning properties to local ports (and it's only really used by the dragonfly topology).
This patch checks for user-defined subcomponents on an hr_router's portcontrol slots during initialization and assigns them to the associated port. This is enough to override any port settings by setting the subcomponent on any router after building a topology in pymerlin.
Also includes a small unit-conversion fix for flit_size in portControl that turned up while testing.