This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
fixed bug with cache entries being overwritten when 'module' was registered under 'module/index' #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's assume there's a module registered under
"test/index"
When you call
require( "test" )
stitch checks if it has such module in cache under"test"
path.If not it checks, if there's such module defined under
"test"
or"test/index"
and tries to load it.In this example, It finds the module under
"test/index"
so it creates cache entry for that path.When the same module is required again, it will be not found in cache and whole cache entry is recreated (module function will be invoked again)