Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mekdimd/add subscribe button #80

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

mekdimd
Copy link
Collaborator

@mekdimd mekdimd commented Oct 7, 2023

Closes issue #66

Tablet/desktop view

Screenshot 2023-10-06 at 8 23 54 PM

Mobile View

Screenshot 2023-10-06 at 8 25 06 PM

@mekdimd mekdimd linked an issue Oct 7, 2023 that may be closed by this pull request
@mekdimd mekdimd requested a review from brianrahadi October 7, 2023 03:56
@brianrahadi
Copy link
Member

Well done! I feel the button is quite distant from the calendar. Might be more helpful to make the button equally close or closer to the calendar rather than the events. I can approve after. Let me know if you have any other thoughts

image

Copy link
Member

@brianrahadi brianrahadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mekdimd mekdimd merged commit 35a468a into master Oct 12, 2023
1 check passed
@mekdimd mekdimd deleted the mekdimd/add-subscribe-button branch October 16, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Subscribe to SSSS events button above calendar
2 participants