Alternative ip5306 battery level handling #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonr
reviewed
Feb 12, 2023
components/ip5306/ip5306.cpp
Outdated
| @@ -40,8 +40,7 @@ void IP5306::loop() { | |||
| case 0x80: value = 75; break; | |||
| case 0x00: value = 100; break; | |||
| } | |||
| if (!this->battery_level_->has_state() || (this->battery_level_->state != value)) | |||
| this->battery_level_->publish_state(value); | |||
| this->battery_level_->publish_state(value); | |||
There was a problem hiding this comment.
should this be indented a little bit more?
There was a problem hiding this comment.
Indeed. Fixed it in my fork, but not sure how to 'republish' this in this pull request.
|
👍 |
Ident on line 43
|
the esp32 camera stuff should be in a different branch |
|
I'm afraid i've got no idea how to split branches AND keep the stuff working for me. Git is not my thing i'm afraid. |
|
you can make a branch off of this branch (to hold onto esp32 cam stuff), and then just delete the esp32 cam folder from this branch. or you could cherry pick the esp32 cam commits onto a new branch, and then checkout commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #45 this would be the proposed changes and some HA integration optimizations for just the ip5306 custom component.