fix: validation mode lower case #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbelitz
force-pushed
the
fix/validation-mode
branch
from
db7601a
to
be004c8
Compare
The check on the validation mode is done by lower casing the input and comparing it to a constant. Unfortunately the constant wasn't entirely lower case. Instead, no lower casing is done anymore, but an exact matching is required. fixes #1816
phbelitz
force-pushed
the
fix/validation-mode
branch
from
be004c8
to
9c95014
Compare
Starkteetje
approved these changes
Nov 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check on the validation mode is done by lower casing the input and comparing it to a constant. Unfortunately the constant wasn't entirely lower case. This has been fixed.
fixes #1816
Description
Checklist
developChart.yaml(if necessary)