-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech][RORDEV-1152] Migrate core and es813x to Scala 3 #1010
Merged
coutoPL
merged 9 commits into
sscarduzio:epic/RORDEV-1152_scala3_migration
from
mgoworko:tech/RORDEV-1152-migrate-core-and-es813x-to-Scala3
May 14, 2024
Merged
[Tech][RORDEV-1152] Migrate core and es813x to Scala 3 #1010
coutoPL
merged 9 commits into
sscarduzio:epic/RORDEV-1152_scala3_migration
from
mgoworko:tech/RORDEV-1152-migrate-core-and-es813x-to-Scala3
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cala3_migration # Conflicts: # tests-utils/src/main/scala/tech/beshu/ror/utils/containers/ElasticsearchNodeWaitingStrategy.scala
…n' into tech/RORDEV-1152-migrate-core-and-es813x-to-Scala3
coutoPL
reviewed
May 5, 2024
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/ImpersonationWarning.scala
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/ImpersonationWarning.scala
Show resolved
Hide resolved
...ain/scala/tech/beshu/ror/accesscontrol/blocks/definitions/ExternalAuthorizationService.scala
Show resolved
Hide resolved
...src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/elasticsearch/DataStreamsRule.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/elasticsearch/FieldsRule.scala
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/elasticsearch/SnapshotsRule.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/tranport/BaseHostsRule.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/utils/CirceOps.scala
Outdated
Show resolved
Hide resolved
mgoworko
commented
May 7, 2024
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/tranport/BaseHostsRule.scala
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/utils/CirceOps.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/tranport/BaseHostsRule.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/elasticsearch/SnapshotsRule.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/elasticsearch/FieldsRule.scala
Show resolved
Hide resolved
...src/main/scala/tech/beshu/ror/accesscontrol/blocks/rules/elasticsearch/DataStreamsRule.scala
Outdated
Show resolved
Hide resolved
...ain/scala/tech/beshu/ror/accesscontrol/blocks/definitions/ExternalAuthorizationService.scala
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/ImpersonationWarning.scala
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/blocks/ImpersonationWarning.scala
Show resolved
Hide resolved
coutoPL
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
coutoPL
merged commit May 14, 2024
0565139
into
sscarduzio:epic/RORDEV-1152_scala3_migration
1 check passed
coutoPL
pushed a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to Scala 3 (3.3.3)