This repository has been archived by the owner on May 3, 2024. It is now read-only.
forked from SierraBay/SierraBay12
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e1088c3.
github-actions
bot
added
🍚 Спрайты
Вы заработали свою миска-рис и кошко-жена. Партия гордится вами!
TGUI
Красивые интерфейсики.
labels
Feb 16, 2024
Gaxeer
approved these changes
Feb 16, 2024
Furrior
reviewed
Feb 16, 2024
Comment on lines
+17
to
+23
if(!istype(Atom, /obj/screen)) | ||
stop_following() | ||
following = Atom | ||
GLOB.destroyed_event.register(Atom, src, PROC_REF(stop_following)) | ||
GLOB.moved_event.register(Atom, src, PROC_REF(keep_following)) | ||
GLOB.dir_set_event.register(Atom, src, TYPE_PROC_REF(/atom, recursive_dir_set)) | ||
keep_following(new_loc = get_turf(following)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if(!istype(Atom, /obj/screen)) | |
stop_following() | |
following = Atom | |
GLOB.destroyed_event.register(Atom, src, PROC_REF(stop_following)) | |
GLOB.moved_event.register(Atom, src, PROC_REF(keep_following)) | |
GLOB.dir_set_event.register(Atom, src, TYPE_PROC_REF(/atom, recursive_dir_set)) | |
keep_following(new_loc = get_turf(following)) | |
if(istype(Atom, /obj/screen)) | |
return | |
stop_following() | |
following = Atom | |
GLOB.destroyed_event.register(Atom, src, PROC_REF(stop_following)) | |
GLOB.moved_event.register(Atom, src, PROC_REF(keep_following)) | |
GLOB.dir_set_event.register(Atom, src, TYPE_PROC_REF(/atom, recursive_dir_set)) | |
keep_following(new_loc = get_turf(following)) |
Furrior
reviewed
Feb 16, 2024
Comment on lines
+601
to
+611
/mob/observer/ghost/proc/add_ghost_buttons() | ||
var/jumptomob = new /obj/screen/ghost/jumptomob() | ||
var/orbit = new /obj/screen/ghost/orbit() | ||
var/reenter_corpse = new /obj/screen/ghost/reenter_corpse() | ||
var/teleport = new /obj/screen/ghost/teleport() | ||
var/toggle_darkness = new /obj/screen/ghost/toggle_darkness() | ||
client.screen.Add(jumptomob) | ||
client.screen.Add(orbit) | ||
client.screen.Add(reenter_corpse) | ||
client.screen.Add(teleport) | ||
client.screen.Add(toggle_darkness) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно сделать статик лист типов кнопок и проходясь по нему, создавать экземпляры и давать клиенту
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Потом рефакторнем
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Копипизднул Orbit и прочие плюшки для гостов - ss220-space/Baystation12#721
Почему это хорошо для игры
Удобно ебать
Изображения изменений
Скриншоты
Тестирование
Ага
Changelog
🆑
add: Добавлены плюшки для гостов, в том числе Orbit
/:cl: