Tweak: Pick Darkness & Ghost Teleport List #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaxeer
reviewed
Dec 2, 2023
modular_ss220/verbs/code/verbs.dm
Outdated
Comment on lines
52
to
63
| switch(darkness_level) | ||
| if("Darkness") | ||
| client.prefs.ghost_darkness_level = 255 | ||
| if("Twilight") | ||
| client.prefs.ghost_darkness_level = 210 | ||
| if("Brightness") | ||
| client.prefs.ghost_darkness_level = 0 | ||
| if("Custom") | ||
| var/new_darkness = input(usr, "Введите новое значение (0 - 255). Больше - темнее.", "Pick Darkness") as null|num | ||
| if(!new_darkness) | ||
| return | ||
| client.prefs.ghost_darkness_level = new_darkness |
There was a problem hiding this comment.
Suggested change
| switch(darkness_level) | |
| if("Darkness") | |
| client.prefs.ghost_darkness_level = 255 | |
| if("Twilight") | |
| client.prefs.ghost_darkness_level = 210 | |
| if("Brightness") | |
| client.prefs.ghost_darkness_level = 0 | |
| if("Custom") | |
| var/new_darkness = input(usr, "Введите новое значение (0 - 255). Больше - темнее.", "Pick Darkness") as null|num | |
| if(!new_darkness) | |
| return | |
| client.prefs.ghost_darkness_level = new_darkness | |
| var/new_darkness | |
| switch(darkness_level) | |
| if("Darkness") | |
| new_darkness = 255 | |
| if("Twilight") | |
| new_darkness = 210 | |
| if("Brightness") | |
| new_darkness = 0 | |
| if("Custom") | |
| new_darkness = input(usr, "Введите новое значение (0 - 255). Больше - темнее.", "Pick Darkness") as null|num | |
| if(!new_darkness) | |
| return | |
| client.prefs.ghost_darkness_level = new_darkness |
|
null потому что 0 игнорировало |
Legendaxe
approved these changes
Dec 4, 2023
AyIong
changed the title
PhantornRU
requested changes
Dec 6, 2023
PhantornRU
approved these changes
Dec 6, 2023
Gaxeer
reviewed
Dec 7, 2023
Co-authored-by: Gaxeer <[email protected]>
Gaxeer
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Заменяет ввод числа в Pick Darkness на список.
Первое осталось, только теперь в виде выбора Custom
Имхо, так гораздо удобнее нежели каждый раз вписывать нужное значение при переключении с темноты/отсутствия темноты на полу-мрак и обратно
Почему это хорошо для игры
УДОБНО
Изображения изменений
Тестирование
Йеп
Changelog
🆑
tweak: Pick Darkness и Ghost Teleport теперь списками, должно быть удобнее. Точное число всё так же можно вписать, оно - Custom выбор
/:cl: