forked from ParadiseSS13/Paradise
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Роли новичков добавлены в консоль ГП #678
Merged
PhantornRU
merged 5 commits into
ss220club:master
from
PhantornRU:novice_identcard_console
Nov 16, 2023
Merged
FEAT: Роли новичков добавлены в консоль ГП #678
PhantornRU
merged 5 commits into
ss220club:master
from
PhantornRU:novice_identcard_console
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legendaxe
approved these changes
Nov 12, 2023
Gaxeer
reviewed
Nov 13, 2023
Gaxeer
reviewed
Nov 13, 2023
Gaxeer
reviewed
Nov 13, 2023
@Gaxeer повторно пересмотрел. Проблем не обнаружил |
Gaxeer
requested changes
Nov 15, 2023
PhantornRU
commented
Nov 15, 2023
Co-authored-by: Gaxeer <[email protected]>
Gaxeer
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Консоль ГП теперь может навешивать работающую иконку новичковой роли и перекрашивать карту.
Модульность позволяет потенциально работать с этим и в будущем.
Почему это хорошо для игры
Да. Хорошо. Нужно больше набранных паровозиков кадетиков, а не то что мы сейчас видели, где ГП извращались с названиями. А ведь офицеры видят кадета-не-кадета, высказывают к ним требования как к офицерам и бедные кадетики перегружают свои головы и умирают задохнувшись от поступившей информации! Убережем кадетиков!
Изображения изменений
Тестирование
Да кому нужны эти тестирования когда есть такие прекрасные скриншоты. КОгда мы уже объединим эти 2 пункта.
Навешиваем роль, проверяем иконку:
Changelog
🆑
tweak: В консоли ГП теперь можно выдавать новичковые роли + перерисовывать их карты.
/:cl: